Discussion:
[PATCH] audit/filter: remove some duplicated includes
Yangtao Li
2018-11-26 15:01:39 UTC
Permalink
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <***@gmail.com>
---
kernel/auditfilter.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index bf309f2592c4..6d43928a41c2 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -22,10 +22,8 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/netlink.h>
#include <linux/sched.h>
--
2.17.0
Paul Moore
2018-11-26 23:38:24 UTC
Permalink
Post by Yangtao Li
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.
---
kernel/auditfilter.c | 2 --
1 file changed, 2 deletions(-)
See my previous comments.
Post by Yangtao Li
diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index bf309f2592c4..6d43928a41c2 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -22,10 +22,8 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/netlink.h>
#include <linux/sched.h>
--
2.17.0
--
paul moore
www.paul-moore.com
Loading...