Discussion:
[PATCH] kernel/audit: remove some duplicated includes
Add Reply
Yangtao Li
2018-11-26 14:58:30 UTC
Reply
Permalink
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <***@gmail.com>
---
kernel/audit_watch.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
index 787c7afdf829..8c8b1a87fd2b 100644
--- a/kernel/audit_watch.c
+++ b/kernel/audit_watch.c
@@ -21,10 +21,8 @@

#include <linux/file.h>
#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/fsnotify_backend.h>
#include <linux/namei.h>
#include <linux/netlink.h>
--
2.17.0
Paul Moore
2018-11-26 23:38:04 UTC
Reply
Permalink
Post by Yangtao Li
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.
---
kernel/audit_watch.c | 2 --
1 file changed, 2 deletions(-)
Same as my previous comments.
Post by Yangtao Li
diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c
index 787c7afdf829..8c8b1a87fd2b 100644
--- a/kernel/audit_watch.c
+++ b/kernel/audit_watch.c
@@ -21,10 +21,8 @@
#include <linux/file.h>
#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/fsnotify_backend.h>
#include <linux/namei.h>
#include <linux/netlink.h>
--
2.17.0
--
paul moore
www.paul-moore.com
Loading...