Discussion:
[PATCH] fsnotify: remove some duplicated includes
Add Reply
Yangtao Li
2018-11-26 14:54:34 UTC
Reply
Permalink
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <***@gmail.com>
---
kernel/audit_fsnotify.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index fba78047fb37..5b54386a9edf 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -16,10 +16,8 @@
*/

#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/fsnotify_backend.h>
#include <linux/namei.h>
#include <linux/netlink.h>
--
2.17.0
Paul Moore
2018-11-26 23:37:43 UTC
Reply
Permalink
Post by Yangtao Li
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.
---
kernel/audit_fsnotify.c | 2 --
1 file changed, 2 deletions(-)
I currently prefer to keep things as-is, see my response to your previous patch.
Post by Yangtao Li
diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index fba78047fb37..5b54386a9edf 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -16,10 +16,8 @@
*/
#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/fsnotify_backend.h>
#include <linux/namei.h>
#include <linux/netlink.h>
--
2.17.0
--
paul moore
www.paul-moore.com
Loading...