Discussion:
[PATCH] audit/sc: remove some duplicated includes
Add Reply
Yangtao Li
2018-11-26 15:05:23 UTC
Reply
Permalink
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <***@gmail.com>
---
kernel/auditsc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index b2d1f043f17f..6b6de6e0540e 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -47,7 +47,6 @@
#include <linux/init.h>
#include <asm/types.h>
#include <linux/atomic.h>
-#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/mm.h>
#include <linux/export.h>
@@ -55,7 +54,6 @@
#include <linux/mount.h>
#include <linux/socket.h>
#include <linux/mqueue.h>
-#include <linux/audit.h>
#include <linux/personality.h>
#include <linux/time.h>
#include <linux/netlink.h>
--
2.17.0
Paul Moore
2018-11-26 23:39:01 UTC
Reply
Permalink
Post by Yangtao Li
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.
---
kernel/auditsc.c | 2 --
1 file changed, 2 deletions(-)
See my previous comments.
Post by Yangtao Li
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index b2d1f043f17f..6b6de6e0540e 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -47,7 +47,6 @@
#include <linux/init.h>
#include <asm/types.h>
#include <linux/atomic.h>
-#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/mm.h>
#include <linux/export.h>
@@ -55,7 +54,6 @@
#include <linux/mount.h>
#include <linux/socket.h>
#include <linux/mqueue.h>
-#include <linux/audit.h>
#include <linux/personality.h>
#include <linux/time.h>
#include <linux/netlink.h>
--
2.17.0
--
paul moore
www.paul-moore.com
Loading...