Discussion:
[PATCH] audit: localize audit_log_session_info prototype
Add Reply
Richard Guy Briggs
2018-11-16 17:16:35 UTC
Reply
Permalink
The audit_log_session_info() function is only used in kernel/audit*, so
move its prototype to kernel/audit.h

Signed-off-by: Richard Guy Briggs <***@redhat.com>
---
include/linux/audit.h | 2 --
kernel/audit.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/audit.h b/include/linux/audit.h
index 9334fbef7bae..58cf665f597e 100644
--- a/include/linux/audit.h
+++ b/include/linux/audit.h
@@ -115,8 +115,6 @@ struct audit_field {

struct filename;

-extern void audit_log_session_info(struct audit_buffer *ab);
-
#define AUDIT_OFF 0
#define AUDIT_ON 1
#define AUDIT_LOCKED 2
diff --git a/kernel/audit.h b/kernel/audit.h
index 214e14948370..9a3828bd387b 100644
--- a/kernel/audit.h
+++ b/kernel/audit.h
@@ -210,6 +210,8 @@ struct audit_context {

extern bool audit_ever_enabled;

+extern void audit_log_session_info(struct audit_buffer *ab);
+
extern void audit_copy_inode(struct audit_names *name,
const struct dentry *dentry,
struct inode *inode);
--
1.8.3.1
Paul Moore
2018-11-19 17:36:58 UTC
Reply
Permalink
Post by Richard Guy Briggs
The audit_log_session_info() function is only used in kernel/audit*, so
move its prototype to kernel/audit.h
---
include/linux/audit.h | 2 --
kernel/audit.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
Merged into audit/next.
Post by Richard Guy Briggs
diff --git a/include/linux/audit.h b/include/linux/audit.h
index 9334fbef7bae..58cf665f597e 100644
--- a/include/linux/audit.h
+++ b/include/linux/audit.h
@@ -115,8 +115,6 @@ struct audit_field {
struct filename;
-extern void audit_log_session_info(struct audit_buffer *ab);
-
#define AUDIT_OFF 0
#define AUDIT_ON 1
#define AUDIT_LOCKED 2
diff --git a/kernel/audit.h b/kernel/audit.h
index 214e14948370..9a3828bd387b 100644
--- a/kernel/audit.h
+++ b/kernel/audit.h
@@ -210,6 +210,8 @@ struct audit_context {
extern bool audit_ever_enabled;
+extern void audit_log_session_info(struct audit_buffer *ab);
+
extern void audit_copy_inode(struct audit_names *name,
const struct dentry *dentry,
struct inode *inode);
--
1.8.3.1
--
paul moore
www.paul-moore.com

Loading...